Repository navigation
Pin MessagePack to 3.1.12 and keep build package versions only in Directory.Build.props - #12
Merged
Merged
Conversation
…ectory.Build.props - MessagePack: `3.*` -> `3.1.12`, the version restore already resolved. It is the newest stable 3.x on nuget.org (4.0.0 is only at rc.1). - Directory.Build.props: Nerdbank.GitVersioning 3.10.94, DotNet.ReproducibleBuilds 2.0.5, Microsoft.SourceLink.GitHub 10.0.404. These are the versions both csproj files forced through `<PackageReference Update=...>`; those overrides are removed. - release.yml: the nbgv comment now points to Directory.Build.props. Resolved packages in obj/project.assets.json are unchanged for both projects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Two leftovers from the package update (internal board, issues 6 and 7):
MessagePackfloated with3.*, so every restore could pick a different version, even with DotNet.ReproducibleBuilds in place.Directory.Build.propsstill named Nerdbank.GitVersioning 3.9.50, DotNet.ReproducibleBuilds 2.0.2 and Microsoft.SourceLink.GitHub 8.0.0. Both csproj files overrode these with<PackageReference Update=…>, so every update had to be made in three places.Changes
EvenBetterFastSim.csproj:MessagePackgoes from3.*to3.1.12, the version restore already resolved. It is the newest stable 3.x on nuget.org (4.0.0 is only at rc.1), and it has no deprecation and no known vulnerability.Directory.Build.props: Nerdbank.GitVersioning 3.10.94, DotNet.ReproducibleBuilds 2.0.5, Microsoft.SourceLink.GitHub 10.0.404. These are the versions theUpdateitems forced until now.ItemGroupwith the three<PackageReference Update=…>lines is gone. The versions now live only inDirectory.Build.props.release.yml: the comment behindnbgv --version 3.10.94now points toDirectory.Build.props. The version itself still matches.Verification
obj/project.assets.jsonbefore and after, with a forced restore of both projects:[3.*, )→[3.1.12, )). The resolved package stays 3.1.12, and every other package is unchanged.msbuild -getItem:PackageReferenceshows the same effective versions in both projects as before: 3.10.94 / 2.0.5 / 10.0.404, each withPrivateAssets=All.bin/Release/net10.0-windows7.0holds the same files with the same SHA-256 hashes as before.EvenBetterFastSim.dll/.exewere left out of the comparison because they carry the commit-based version.Directory.Build.propsare these two, so no other project picks up a different version.actionlint1.7.12 onrelease.ymlandci.yml: no findings.windows-latest) is the first check there.Merge
Please use a squash merge. A merge to
mainchanges project files and therefore triggersrelease.yml, which publishes the next pre-release (v1.0.0-build.6 if the pattern holds). The bundled runtime stays the same as in v1.0.0-build.5.Internal board (secsgem/evencoolerfastsim): implements issues 6 and 7.
🤖 Generated with Claude Code